Review requested:

• @nodejs/test_runner

I bring with me my concerns from the other PR, but I'm curious what others think

I bring with me my concerns from the other PR, but I'm curious what others think

Now I see what you meant. I will dig into it.

Codecov Report

Attention: Patch coverage is 44.44444% with 15 lines in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (deb5eff) to head (6391e6e).
Report is 19 commits behind head on main.

@@            Coverage Diff             @@
##             main   #55228      +/-   ##
==========================================
- Coverage   88.41%   88.40%   -0.02%     
==========================================
  Files         652      652              
  Lines      186756   186785      +29     
  Branches    36100    36101       +1     
==========================================
- Hits       165126   165119       -7     
- Misses      14906    14931      +25     
- Partials     6724     6735      +11     

Codecov Report

Attention: Patch coverage is 44.44444% with 15 lines in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (98788da) to head (c0deb06).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/test_runner/coverage.js 44.44% 15 Missing ⚠️
Additional details and impacted files

@@            Coverage Diff             @@
##             main   #55228      +/-   ##
==========================================
+ Coverage   87.89%   88.40%   +0.51%     
==========================================
  Files         652      652              
  Lines      186589   186638      +49     
  Branches    35750    36054     +304     
==========================================
+ Hits       163999   165003    +1004     
+ Misses      15816    14904     -912     
+ Partials     6774     6731      -43     

Files with missing lines Coverage Δ
lib/internal/test_runner/coverage.js 63.86% <44.44%> (-0.83%) ⬇️
... and 96 files with indirect coverage changes

how's this possible?

how's this possible?

In my experience, codecov isn't always exactly accurate. Regardless, it's nothing to be concerned about.

CI: https://ci.nodejs.org/job/node-test-pull-request/62948/

CI: https://ci.nodejs.org/job/node-test-pull-request/62958/

Test is failing with

✖ should throw when a source map is not valid JSON (73.0115ms)
  AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

    t.assert.ok(spawned.stdout.includes(error))

      at TestContext.<anonymous> (/Users/edysilva/projects/contributions/node/test/parallel/test-runner-coverage-source-map.js:118:16)
      at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
      at async Test.run (node:internal/test_runner/test:935:9)
      at async Suite.processPendingSubtests (node:internal/test_runner/test:633:7) {
    generatedMessage: true,
    code: 'ERR_ASSERTION',
    actual: false,
    expected: true,
    operator: '=='
  }

test at test/parallel/test-runner-coverage-source-map.js:113:11

would you have any clue @RedYetiDev ? Looks like tests are somehow interfering with each other. If I execute this ^ isolatedly it works. Thanks in advance.

EDIT: on CI, mine fails. Not sure what caused that.

EDIT: on CI, mine fails. Not sure what caused that.

If you can reproduce the failure locally, it might help to have it log the output to see what the actual difference is.

EDIT: on CI, mine fails. Not sure what caused that.

If you can reproduce the failure locally, it might help to have it log the output to see what the actual difference is.

It's the assertion on stdout

TAP version 13
# Subtest: /Users/edysilva/projects/contributions/node/test/fixtures/test-runner/source-maps/invalid-json/index.js
ok 1 - /Users/edysilva/projects/contributions/node/test/fixtures/test-runner/source-maps/invalid-json/index.js
  ---
  duration_ms: 38.544167
  ...
1..1
# Warning: Could not report code coverage. TypeError: Cannot read properties of null (reading 'sourcesContent')
# tests 1
# suites 0
# pass 1
# fail 0
# cancelled 0
# skipped 0
# todo 0
# duration_ms 43.42

this message is not being printed.

When I run ./node --test --experimental-test-coverage --test-reporter tap test/fixtures/test-runner/source-maps/missing-sources/index.js it prints the message though.

TAP version 13
# Subtest: test/fixtures/test-runner/source-maps/missing-sources/index.js
ok 1 - test/fixtures/test-runner/source-maps/missing-sources/index.js
  ---
  duration_ms: 301.77525
  ...
1..1
# Warning: Could not report code coverage. Error [ERR_SOURCE_MAP_MISSING_SOURCE]: Cannot find 'file:///Users/edysilva/projects/contributions/node/test/fixtures/test-runner/source-maps/missing-sources/nonexistent.js' imported from the source map for 'file:///Users/edysilva/projects/contributions/node/test/fixtures/test-runner/source-maps/missing-sources/index.js'
# tests 1
# suites 0
# pass 1
# fail 0
# cancelled 0
# skipped 0
# todo 0
# duration_ms 305.851208

Sorry @RedYetiDev . Newbie working. I think I need to recompile

Try rebasing to include your other PR?

CI: https://ci.nodejs.org/job/node-test-pull-request/62991/

Landed in 3a42085

This Refs two issues. Does it actually fix either/both of them?

This Refs two issues. Does it actually fix either/both of them?

I'd say yes. I'm pretty sure it solves #54753. Could you confirm for #55106 @RedYetiDev ?

There aren't any tests to confirm that, can you no longer reproduce the errors described? I would assume your other PR fixes that one